Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnicodeDecodeError when checking Msvc tool #779

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Fix UnicodeDecodeError when checking Msvc tool #779

merged 2 commits into from
Dec 22, 2022

Commits on Dec 22, 2022

  1. fix: unicode decoding error 

    According to Python 3 documentation https://docs.python.org/3/library/subprocess.html:
If encoding or errors are specified, or text is true, file objects for stdin, stdout and stderr are opened in text mode using the specified encoding and errors or the io.TextIOWrapper default.
    @yihuajack
    yihuajack committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    e4b5374 View commit details
    Browse the repository at this point in the history

  2. Fix lint errors

    @danyeaw
    danyeaw committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6abcbe9 View commit details
    Browse the repository at this point in the history