Split "release" from "debug-optimized" configuration #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchhentges
force-pushed
the
release-without-debug-symbols
branch
from
f1dab00
to
ae6fb88
Compare
|
I've run |
mitchhentges
force-pushed
the
release-without-debug-symbols
branch
from
ae6fb88
to
1d276ca
Compare
|
I am ok with this proposal, but I would stick to the meson terminology instead of the cmake one, so I would call it |
Some downstream projects may want to avoid the size cost of including debug symbols in packaged libraries. This change maintains the default of continuing to keep debug symbols in Meson and CMake projects, but now provides an opt-out via the "--configuration" option. Note: ideally, this state wouldn't have to be spread over two variables, but I wanted to avoid the potential breakage risk involved with having `opts.configuration` be something other than the common `"debug"` and `"release"` strings, considering how it's used directly in quite a few places.
mitchhentges
force-pushed
the
release-without-debug-symbols
branch
from
1d276ca
to
d5da07e
Compare
mitchhentges
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some downstream projects may want to avoid the size cost of including debug symbols in packaged libraries.
This change maintains the default of continuing to keep debug symbols in Meson and CMake projects, but now provides an opt-out via the "--configuration" option.
Note: ideally, this state wouldn't have to be spread over two variables, but I wanted to avoid the potential breakage risk involved with having
opts.configurationbe something other than the common"debug"and"release"strings, considering how it's used directly in quite a few places.