Skip to content

Commit

Permalink
Refs wymeditor#249. Upgraded rangy to 1.1.2 to take advantage of rang…
Browse files Browse the repository at this point in the history
…y.getIframeSelection
  • Loading branch information
winhamwr committed Jun 24, 2011
1 parent 4a35df9 commit eee0c2d
Show file tree
Hide file tree
Showing 8 changed files with 121 additions and 122 deletions.
3 changes: 1 addition & 2 deletions src/test/unit/table_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ function testRowMerge(

// Use rangy to get a cross-browser selection object and perform the actual
// merge
var iframeWin = wymeditor._iframe.contentDocument ? wymeditor._iframe.contentDocument.defaultView : wymeditor._iframe.contentWindow;
var sel = rangy.getSelection(iframeWin);
var sel = rangy.getIframeSelection(wymeditor._iframe);
var changesMade = wymeditor.tableEditor.mergeRow(sel);
equals(changesMade, true);

Expand Down
3 changes: 1 addition & 2 deletions src/test/unit/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ function makeSelection(
if (endElementIndex == null) {
endElementIndex = 0;
}
var iframeWin = wymeditor._iframe.contentDocument ? wymeditor._iframe.contentDocument.defaultView : wymeditor._iframe.contentWindow;
var sel = rangy.getSelection(iframeWin);
var sel = rangy.getIframeSelection(wymeditor._iframe);

var range = rangy.createRange(wymeditor._doc);
range.setStart(startElement, startElementIndex);
Expand Down
10 changes: 4 additions & 6 deletions src/wymeditor/plugins/rangy/jquery.wymeditor.rangy.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
if(window.rangy && !rangy.initialized) rangy.init();

var iframe = this._iframe;
var win = (iframe.contentDocument && iframe.contentDocument.defaultView) ?
iframe.contentDocument.defaultView : iframe.contentWindow;
var sel = rangy.getSelection(win);
var sel = rangy.getIframeSelection(iframe);

return(sel);
};
Expand All @@ -50,7 +48,7 @@
WYMeditor.editor.prototype.selection_collapsed = function() {
var sel = this.selection();
var collapsed = false;

$.each(sel.getAllRanges(), function() {
if(this.collapsed) {
collapsed = true;
Expand All @@ -61,15 +59,15 @@

return(collapsed);
};

/* @name selected_contains
* @description Returns an array of nodes that match a jQuery selector
* within the current selection.
*/
WYMeditor.editor.prototype.selected_contains = function(selector) {
var sel = this.selection();
var matches = [];

$.each(sel.getAllRanges(), function() {
$.each(this.getNodes(), function() {
if($(this).is(selector)) {
Expand Down
159 changes: 81 additions & 78 deletions src/wymeditor/plugins/rangy/rangy-core.js

Large diffs are not rendered by default.

28 changes: 15 additions & 13 deletions src/wymeditor/plugins/rangy/rangy-cssclassapplier.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions src/wymeditor/plugins/rangy/rangy-selectionsaverestore.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit eee0c2d

Please sign in to comment.