Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of the library to TypeScript #2

Merged
merged 6 commits into from
Apr 2, 2019

Conversation

vladimirmoushkov
Copy link
Contributor

Removed 'react-scripts' in place of web pack.
Use:
npm run build:prod
to produce ./lib/ npm pack able directory that includes javascript and type definitions.

Note there is a problem with the displaying of some to the inks:

s.default is not a function...

@winhtaikaung
Copy link
Owner

winhtaikaung commented Mar 30, 2019

Hi @vladimirmoushkov,
Thank you .It was great help for me and really appreciated that you spend time on me to migrate to typescript. But there are some small glitches on missing files in your commit demo.tsx and .env
Please refer to following screenshots.

demo.tsx missing

Screenshot from 2019-03-30 16-56-56

.env missing

Screenshot from 2019-03-30 16-58-06

Thanks
Win

Vladimir Moushkov added 4 commits March 30, 2019 18:46
- fixes for cheerio and lodash / isEmpty usage
@vladimirmoushkov
Copy link
Contributor Author

vladimirmoushkov commented Mar 30, 2019 via email

@winhtaikaung
Copy link
Owner

Hi @vladimirmoushkov, 💯 Thanks for prompt response. Really appreciate it. I will check it soon and will look into the issue .

Cheers
Win

@winhtaikaung winhtaikaung changed the base branch from master to type-script April 2, 2019 06:24
@winhtaikaung winhtaikaung changed the base branch from type-script to master April 2, 2019 06:24
@winhtaikaung winhtaikaung changed the base branch from master to type-script April 2, 2019 06:25
@winhtaikaung winhtaikaung merged commit b23ec79 into winhtaikaung:type-script Apr 2, 2019
@vladimirmoushkov
Copy link
Contributor Author

vladimirmoushkov commented Apr 2, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants