-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion of the library to TypeScript #2
Merged
winhtaikaung
merged 6 commits into
winhtaikaung:type-script
from
vladimirmoushkov:master
Apr 2, 2019
Merged
Conversion of the library to TypeScript #2
winhtaikaung
merged 6 commits into
winhtaikaung:type-script
from
vladimirmoushkov:master
Apr 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @vladimirmoushkov, demo.tsx missing.env missingThanks |
- fixes for cheerio and lodash / isEmpty usage
Hello,
Apology for being clutter here!
I have added a demo page for *npm run start* and empty .env file for *npm
run deploy. *If you like to run the latter you will need to fill the .env
file with npmjs registry creds and etc. Feel free to remove any
packages.json you won't find useful. I have copied these from another
project. The only one needed is build:lib and start.
Did also fix couple of import issues but tiny link seems is unable to
handle all of the links I'm trying, see the screenshot below:
[image: Screenshot 2019-03-30 at 18.45.35.png]
…On Sat, Mar 30, 2019 at 11:03 AM Win Htaik Aung ***@***.***> wrote:
Hi @vladimirmoushkov <https://github.com/vladimirmoushkov>,
Thank you .It was great help for me and really appreciated that you spend
time on me to migrate to typescript. But there are some small glitches on
missing files in your commit demo.tsx and .env
Please refer to following screenshots.
demo.tsx missing
[image: Screenshot from 2019-03-30 16-56-56]
<https://user-images.githubusercontent.com/6395793/55273970-93270900-530d-11e9-9207-c9d65363f98b.png>
.env missing
[image: Uploading Screenshot from 2019-03-30 16-58-06.png…]
Thanks
Win
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUPfoFZOMEfocXzACkmc_hKe_mmsWjkfks5vbyhagaJpZM4cSbqn>
.
|
Hi @vladimirmoushkov, 💯 Thanks for prompt response. Really appreciate it. I will check it soon and will look into the issue . Cheers |
Thank you Win Htaik Aung!
Any plans of dates for future release?
…On Tue, Apr 2, 2019 at 9:25 AM Win Htaik Aung ***@***.***> wrote:
Merged #2 <#2> into
type-script.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUPfoKFGLtMFYDYRiNxVFc0DYENhka9Iks5vcvfQgaJpZM4cSbqn>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 'react-scripts' in place of web pack.
Use:
npm run build:prod
to produce ./lib/ npm pack able directory that includes javascript and type definitions.
Note there is a problem with the displaying of some to the inks: