Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose useScrapper hook #87

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Conversation

kalimantos
Copy link
Contributor

@kalimantos kalimantos commented Dec 21, 2020

As requested in feature request #77
I changed the input params accepted by the hook in a object config to make the call easier without optional parameters
for example if i want to call useScrapper with just url and onSuccess
before:

useScrapper(
  'myURL', 
  undefined, 
  undefined, 
  undefined, 
  undefined, 
  () => console.log('success!!')
);

after:

useScrapper({
  url: 'myURL',
  onSuccess: () => console.log('success!!')
})

@winhtaikaung winhtaikaung merged commit 9cbaf85 into winhtaikaung:master Dec 21, 2020
@kalimantos kalimantos deleted the expose-hook branch December 21, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants