Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ContentDialog's title as header for benefit of screen readers #1176

Closed
rigdern opened this issue May 22, 2015 · 0 comments
Closed

Mark ContentDialog's title as header for benefit of screen readers #1176

rigdern opened this issue May 22, 2015 · 0 comments
Assignees
@rigdern
Labels
feature: contentdialog .kind: codebug ..pri: 1
Milestone
1507

Comments

@rigdern
Copy link
Contributor

rigdern commented May 22, 2015

This was extracted from #928.

Try using header for Dialog title so that narrator says “[Dialog title] header” - either use h2 element or use aria role = header.
@rigdern rigdern mentioned this issue May 22, 2015
Closed
@mikewjackson mikewjackson added this to the 1507 milestone Jun 19, 2015
rigdern pushed a commit that referenced this issue Aug 17, 2015
Fix #1176: Make ContentDialog's title a header
cf7098f 
ContentDialog's title is now marked as a header for consumption by screen
readers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rigdern rigdern

Labels
feature: contentdialog .kind: codebug ..pri: 1
Projects
None yet
Milestone
1507
Development

No branches or pull requests
2 participants
@rigdern @mikewjackson