Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactoring #3

Merged
merged 16 commits into from Dec 29, 2011
Merged

Major refactoring #3

merged 16 commits into from Dec 29, 2011

Conversation

igorw
Copy link
Contributor

@igorw igorw commented Dec 28, 2011

I realize this is quite a big pull request with lots of changes. This is how I would make a library that's more re-usable. A summary of the changes I made:

  • lots of shifting around files and directories
  • use the "Mongrel2" namespace
  • follow the PSR-0 naming convention (this allows autoloading)
  • add a composer.json so it can be installed via composer
  • improved README

My hope is that with these changes (most notably the PSR-0 and composer ones) we can get more re-use of this code. Right now the AiP guys implemented their own mongrel2 parsing (see here). Same goes for photon.

I say it's about time someone hit them over the head with a baseball bat. Just kidding, but we need more re-use. Feel free to just pick out parts of these changes if you don't like them.

@winks
Copy link
Owner

winks commented Dec 29, 2011

That is awesome, thanks a lot - I'll see what I can do in the next days.

winks added a commit that referenced this pull request Dec 29, 2011
Major refactoring - looks good
@winks winks merged commit b7d87bf into winks:master Dec 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants