-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage is not 100% #8
Comments
I tested this with python 3.7 and 3.8, the same results. |
TODO: File a bug on mypy? |
A solution would be don't be "tricky" with using Optionals, but I think its "useful". We'll see :) |
Another solution would be to add a |
Code coverage is not 100%
The reason is that there is an extraenous "if" statement that
can't be tested. This is necessary so
make mypy
works andif mypy worked the "if" statement wouldn't be necessary and
we'd then have 100% coverage.
What I Did
The reason
make coverage
is not 100%:Because to allow
make mypy
to pass:The following code is added to helix.py:
If you comment the code the following are the results of
make mypy
:The text was updated successfully, but these errors were encountered: