Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to be more clear #7

Closed
amirci opened this issue Jan 14, 2014 · 2 comments
Closed

Fix tests to be more clear #7

amirci opened this issue Jan 14, 2014 · 2 comments

Comments

@amirci
Copy link
Contributor

amirci commented Jan 14, 2014

Test should be refactored to be more descriptive and clear

@dbernar1
Copy link
Contributor

dbernar1 commented Feb 9, 2014

I believe you had opened this issue based on the discussion we had after you wrote the first feature for the project. A discussion I initiated. Please let me know if that's not the case.

I have now elaborated on my idea for how to make the tests be more descriptive and clear through the code in this pull request: #28 . My first comment, and some of the discussion in pull request #25 also deals with this topic.

If you perceive that the way I've adjusted the tests is a good way to go forward, I can offer to adjust the rest of the existing tests in the same fashion, or we can ask for volunteers. Maybe others would like to get some practice with this.

If you already see issues with how I've implemented those tests, please let me know. I'd appreciate the opportunity to learn how to write better tests.

@amirci
Copy link
Contributor Author

amirci commented Mar 13, 2014

I think we can rewrite it using page objects to make it more clear. See #15

@amirci amirci closed this as completed Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants