fix(char)!: Generalize textual number parsing #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We infer the type as it is not critical to the grammar, so it can be implicit. BREAKING CHANGE: `nom8`s `number::hex_u32` is removed.
We can just use type inference for which to use as its a question of overflow and not the grammar.
Looks like these were exposed as implementation details and not user requests BREAKING CHANGE: `nom8`'s `character::recognize_float*` functions are removed
The exact type only has overflow properties and does not otherwise affect the parsing of the grammar. BREAKING CHANGE: Compared to `nom8`, `character::u8` and friends are replaced by `character::dec_uint` and `character::dec_int`.
Pull Request Test Coverage Report for Build 4108372374Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In binary number parsing, the exact data type is critical to parsing, so we want to keep that front and center. However, when parsing text, the data type is an implementation detail except for overflow constraints, so let's consolidate to generalized parsers for decimal integers, hexadecimal integers, and float numbers where the type will be inferred. The json examples are a great example of this.
This did involve a bug fix to
hex_uintto be more consistent with the others: we will give an overflow error if there are extra hex characters.Fixes #121