Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bytes)!: Ensure take_while_m_n handles UTF-8 correctly #130

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 7, 2023

Fixes #93

BREAKING CHANGE: take_while_m_n now errors if n < m

@coveralls
Copy link

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4110103367

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 30 of 31 (96.77%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 57.606%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bytes/streaming.rs 16 17 94.12%
Files with Coverage Reduction New Missed Lines %
src/character/complete.rs 2 81.45%
Totals Coverage Status
Change from base Build 4108478849: 0.4%
Covered Lines: 1742
Relevant Lines: 3024

💛 - Coveralls

@epage epage force-pushed the while branch 2 times, most recently from 61e3372 to 888a6a0 Compare February 7, 2023 03:03
@epage epage merged commit 8ad67de into winnow-rs:main Feb 7, 2023
@epage epage deleted the while branch February 7, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

take_while_m_n is invalid for multi-byte UTF-8 characters
2 participants