Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify naming #239

Merged
merged 12 commits into from Apr 27, 2023
Merged

fix: Clarify naming #239

merged 12 commits into from Apr 27, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Apr 27, 2023

Based on #95 and includes:

  • binary includes:
    • number
    • bits
    • multi::length_*
  • bytes -> token
  • character -> ascii
  • combinator includes
    • multi
    • sequence
    • branch
  • Parser::map_res -> Parser::try_map

Still don't have a better name for tag or alt...

@coveralls
Copy link

coveralls commented Apr 27, 2023

Pull Request Test Coverage Report for Build 4824141511

  • 180 of 384 (46.88%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.02%) to 50.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ascii/mod.rs 1 4 25.0%
src/branch.rs 0 3 0.0%
src/parser.rs 4 8 50.0%
src/sequence.rs 0 4 0.0%
src/bits.rs 0 6 0.0%
src/multi.rs 0 16 0.0%
src/character.rs 0 25 0.0%
src/combinator/core.rs 44 79 55.7%
src/number.rs 0 42 0.0%
src/combinator/parser.rs 115 181 63.54%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 1 20.0%
Totals Coverage Status
Change from base Build 4822221633: -2.02%
Covered Lines: 1288
Relevant Lines: 2536

💛 - Coveralls

@epage epage merged commit 65cbf5b into winnow-rs:main Apr 27, 2023
14 checks passed
@epage epage deleted the name branch April 27, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants