Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derive Default for (Stateful|Recoverable) #525

Merged
merged 1 commit into from
May 28, 2024

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang zty0826@gmail.com

Resolve #524

@TennyZhuang TennyZhuang changed the title feat: derive Default for Stateful feat: derive Default for (Stateful|Recoverable) May 22, 2024
@TennyZhuang
Copy link
Contributor Author

I forgot to add feature guard in yesterday's commit, and now it's fixed.

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang
Copy link
Contributor Author

Can the PR got merged? Thanks @epage

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9201969139

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 41.688%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stream/mod.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/error.rs 1 23.61%
src/parser.rs 3 25.0%
src/stream/mod.rs 4 25.48%
Totals Coverage Status
Change from base Build 8963659680: 0.04%
Covered Lines: 1284
Relevant Lines: 3080

💛 - Coveralls

@epage epage enabled auto-merge May 28, 2024 16:49
@epage epage merged commit 99cbbd9 into winnow-rs:main May 28, 2024
14 of 15 checks passed
@TennyZhuang TennyZhuang deleted the derive-default-stateful branch May 29, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

derive Default for Stateful
3 participants