Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Swipe to go back doesn't pop off stack #1

Closed
meno1 opened this issue Feb 12, 2017 · 2 comments
Closed

Swipe to go back doesn't pop off stack #1

meno1 opened this issue Feb 12, 2017 · 2 comments
Assignees
Labels

Comments

@meno1
Copy link

meno1 commented Feb 12, 2017

Great job on integrating react-router v4 into a feature navigation library.

If you go to the Huge example, click on Feed, click on an Item, click Next Item (3x), then swipe back 3x, you will see the back arrow in the Item header that can be pressed 3x to take you back (but this actually doesn't do anything since there is no where to go back).

Now repeat, but this time use the back button instead of swiping back. You'll see that the back button disappears because it recognizes you have gone back all the way.

Also, if you hit the search tab, the search text is in the status bar.

@LeoLeBras
Copy link
Member

LeoLeBras commented Feb 13, 2017

Thanks for your feedback @addyosmani. I'll fix this issue in next release (beta).

@LeoLeBras LeoLeBras added this to the v1.0.0-beta milestone Feb 13, 2017
@LeoLeBras LeoLeBras self-assigned this Feb 15, 2017
@LeoLeBras
Copy link
Member

LeoLeBras commented Mar 1, 2017

54faaf8 - New <Navigation /> component implements swipe to go back !

@LeoLeBras LeoLeBras mentioned this issue Nov 10, 2018
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants