Property route undefined on replacement of route

[georgberecz]

Hey Leo,
thanks for looking into #23 and updating the Renderer. The rendering of multiple cards is not a problem anymore. However, there is now an error inside the NavBar:

I'm using the newest release candidate:
"react-router-navigation": "^1.0.0-rc.2",

I looked into the code and I think I've found something. In the DefaultRenderer replacing
return [ ...acc.slice(0,indexOf), scene ]
with
return [...acc]
and therefore, using the last occurrence in case of finding a duplicate index fixed it for me. With the old code the newly replaced route was simply sliced of again and replaced by the old one. However, the scene in the ownProps was still the new one, but could not be found in the newly generated scenes, which resulted in the exception.

Thanks for looking into that and keep up the good work,
Georg

[LeoLeBras]

Hello @georgberecz ,
I can't reproduce your issue. You should consider creating a minimal test case to demonstrate the issue you're having 😀

[vlad-zhukov]

Wasn't it fixed by #25?

[LeoLeBras]

@georgberecz ?

[CharlesMangwa]

Hi @georgberecz! Did you give a shot to the new ß3? Feel free to keep us update about your issue :)

[LeoLeBras]

Closing due to inactivity

[krishnaff]

Thanks @georgberecz

This actually worked
return [ ...acc.slice(0,indexOf), scene ]
with
return [...acc]

I was getting the same error when using history.replace("...") the second time. It works the first time though.

[LeoLeBras]

@insaneinc01 Do you have an example (or a Github) repo that reproduces the issue?

[LeoLeBras]

This should be fixed in 1.0.0-rc.5