Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

iPhone X support #55

Closed
alexisbronchart opened this issue Dec 8, 2017 · 7 comments
Closed

iPhone X support #55

alexisbronchart opened this issue Dec 8, 2017 · 7 comments
Assignees

Comments

@alexisbronchart
Copy link

Is any support for the iPhone X planned?
Right now the safe area layout guides don't seem to be used.

@nansthomas
Copy link
Contributor

Please !! Add support for iPhone X !

@alexisbronchart
Copy link
Author

alexisbronchart commented Dec 8, 2017

Actually since this depends on react-navigation I guess we should use their SafeAreaView to achieve this. @LeoLeBras could you confirm?

@LeoLeBras LeoLeBras mentioned this issue Dec 9, 2017
18 tasks
@LeoLeBras LeoLeBras self-assigned this Dec 9, 2017
@LeoLeBras LeoLeBras added this to the 1.0.0-stable milestone Dec 9, 2017
@markv
Copy link

markv commented Jan 23, 2018

@LeoLeBras How far away is this feature? I'd like to keep using this library but this is holding me back.

@LeoLeBras
Copy link
Member

LeoLeBras commented Jan 23, 2018

@markv react-router-navigation@1.0.0-rc.4 add partial support for iPhone X. The minimal-app example works on iPhone X but the other example realm-world-app is not.

I didn't have time to investigate the issue. But as @alexisbronchart suggested, using <SafeAreaView /> should correct the problem.

Would you be available to help correct this issue and make the example realm-world-app work ? 😍

@markv
Copy link

markv commented Jan 24, 2018

Using react-router-navigation@1.0.0-rc.4 fixed the header overlap issue i was having

@LeoLeBras
Copy link
Member

LeoLeBras commented Mar 10, 2018

Work in progress ➡️ #56

@LeoLeBras LeoLeBras removed this from the v1.0.0-stable milestone Mar 10, 2018
@LeoLeBras
Copy link
Member

LeoLeBras commented Mar 15, 2018

@markv @alexisbronchart @nansthomas iPhoneX support is live with v1.0.0-rc.5 ! 📱🌈

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants