Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

TypeScript type declarations #58

Closed
vladinator1000 opened this issue Jan 3, 2018 · 7 comments
Closed

TypeScript type declarations #58

vladinator1000 opened this issue Jan 3, 2018 · 7 comments

Comments

@vladinator1000
Copy link

vladinator1000 commented Jan 3, 2018

I'm super excited about this library. 😭

Does anyone feel like working on TypeScript type declarations with me?
We can add them to https://github.com/DefinitelyTyped/DefinitelyTyped

@vladinator1000 vladinator1000 changed the title TypeScript type definitions TypeScript type declarations Jan 3, 2018
@LeoLeBras
Copy link
Member

Hey @savovs ,
This PR adds typescript definitions to react-router-navigation (@kaoDev). I do not use TypeScript myself. I think the best thing to do would be to put this PR to https://github.com/DefinitelyTyped/DefinitelyTyped ! 😎

@LeoLeBras
Copy link
Member

Oups, sorry I forgot the link of the PR : #36

@kaoDev
Copy link

kaoDev commented Jan 22, 2018

hey sorry for the late response, I was a little occupied the last weeks.

@savovs I will transfer the PR today to DefinitelyTyped, but I will need some extra time to update it to the last changes since I opened it.

@LeoLeBras
Copy link
Member

Awesome 😬 thank you very much !

@kaoDev
Copy link

kaoDev commented Jan 25, 2018

the declarations got merged to the DefinitelyTyped Repo 😀 https://www.npmjs.com/package/@types/react-router-navigation

it took a bit longer than expected because I had a discussion about using types instead of interfaces
DefinitelyTyped/DefinitelyTyped#23114 (comment)

@LeoLeBras LeoLeBras self-assigned this Mar 10, 2018
@pixelknitter
Copy link

@kaoDev @LeoLeBras I'm setting up my project, how would I make sure that react-router-navigation has the TypeScript definitions?

would yarn add react-router react-router-native react-router-navigation simply work for my existing TypeScript project? or would I need to add some identifier to the TypeScript specifics?

@NeverFearTheasHere
Copy link

@NinjaSudo you would need to add the type declarations from DefinitelyTyped by running:
yarn add @types/react-router-navigation --dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants