With application logging enabled, automatic updates installation is s…

…tarted with logging too Source commit: 495f301b4648efcdb080dfc608d4de8e8ec85c79
winscp · Aug 20, 2023 · eb27408 · eb27408
1 parent 6f231ac
commit eb27408
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/source/core/SessionInfo.cpp b/source/core/SessionInfo.cpp
@@ -1793,7 +1793,8 @@ TApplicationLog::~TApplicationLog()
 void TApplicationLog::Enable(const UnicodeString & Path)
 {
   UnicodeString Dummy;
-  FFile = OpenFile(Path, Now(), NULL, false, Dummy);
+  FPath = Path;
+  FFile = OpenFile(FPath, Now(), NULL, false, Dummy);
   FLogging = true;
 }
 //---------------------------------------------------------------------------

diff --git a/source/core/SessionInfo.h b/source/core/SessionInfo.h
@@ -370,8 +370,10 @@ class TApplicationLog
   void AddStartupInfo();
   void __fastcall Log(const UnicodeString & S);
   __property bool Logging = { read = FLogging };
+  __property UnicodeString Path = { read = FPath };
 
 private:
+  UnicodeString FPath;
   void * FFile;
   bool FLogging;
   std::unique_ptr<TCriticalSection> FCriticalSection;

diff --git a/source/windows/Setup.cpp b/source/windows/Setup.cpp
@@ -1400,10 +1400,15 @@ void __fastcall TUpdateDownloadThread::UpdateDownloaded()
   {
     Params += L" /OpenGettingStarted";
   }
+  if (ApplicationLog->Logging)
+  {
+    Params += FORMAT(" /LOG=\"%s\"", (ApplicationLog->Path + L".setup"));
+  }
 
   ExecuteShellChecked(SetupPath, Params);
 
   Configuration->Usage->Inc(L"UpdateRuns");
+  AppLog(L"Terminating to allow installation...");
   TerminateApplication();
 }
 //---------------------------------------------------------------------------