[fix] free memory pool in rtmp core/live server conf #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this module is built with ASAN, running it wil receive several
memory leak reports:
Direct leak of 48 byte(s) in 1 object(s) allocated from:
...
winshining#3 0xd6e96a in ngx_rtmp_live_merge_app_conf /home/vagrant/git/nginx-http-flv-module/ngx_rtmp_live_module.c:275:18
winshining#4 0xd06a87 in ngx_rtmp_block /home/vagrant/git/nginx-http-flv-module/ngx_rtmp.c:283:22
...
Direct leak of 48 byte(s) in 1 object(s) allocated from:
...
winshining#3 0xd3edc7 in ngx_rtmp_core_merge_srv_conf /home/vagrant/git/nginx-http-flv-module/ngx_rtmp_core_module.c:407:22
...
This fix is expected to mute the report.
winshining
reviewed
Mar 3, 2020
| ngx_rtmp_live_app_conf_t *lacf; | ||
|
|
||
| lacf = ngx_pcalloc(cf->pool, sizeof(ngx_rtmp_live_app_conf_t)); | ||
| if (lacf == NULL) { | ||
| return NULL; | ||
| } | ||
|
|
||
| cln = ngx_pool_cleanup_add(cf->pool, 0); |
There was a problem hiding this comment.
Placing these code snippets in ngx_rtmp_live_merge_app_conf will fix the memory leak?
Doing so keeps style consistent to the above one.
|
Would you please test what I commented? |
|
@winshining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this module is built with ASAN, running it wil receive several
memory leak reports:
This fix is expected to mute the report.