CustomBuildTool github cert validation

winsiderss · Jul 1, 2024 · 3811a00 · 3811a00
1 parent 579ae12
commit 3811a00
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 28 deletions.
diff --git a/tools/CustomBuildTool/Github.cs b/tools/CustomBuildTool/Github.cs
@@ -49,13 +49,7 @@ public static GithubReleasesResponse CreateRelease(string Version)
                 {
                     httpClientHandler.AutomaticDecompression = DecompressionMethods.All;
                     httpClientHandler.SslProtocols = SslProtocols.Tls12 | SslProtocols.Tls13;
-                    httpClientHandler.ServerCertificateCustomValidationCallback = (sender, cert, chain, sslPolicyErrors) =>
-                    {
-                        if (sslPolicyErrors != SslPolicyErrors.None)
-                            return false;
-
-                        return cert.Subject.Equals("CN=*.github.com", StringComparison.OrdinalIgnoreCase);
-                    };
+                    httpClientHandler.ServerCertificateCustomValidationCallback = CertValidationCallback;
 
                     using (HttpClient httpClient = new HttpClient(httpClientHandler))
                     {
@@ -127,13 +121,7 @@ public static bool DeleteRelease(string Version)
                 {
                     httpClientHandler.AutomaticDecompression = DecompressionMethods.All;
                     httpClientHandler.SslProtocols = SslProtocols.Tls12 | SslProtocols.Tls13;
-                    httpClientHandler.ServerCertificateCustomValidationCallback = (sender, cert, chain, sslPolicyErrors) =>
-                    {
-                        if (sslPolicyErrors != SslPolicyErrors.None)
-                            return false;
-
-                        return cert.Subject.Equals("CN=*.github.com", StringComparison.OrdinalIgnoreCase);
-                    };
+                    httpClientHandler.ServerCertificateCustomValidationCallback = CertValidationCallback;
 
                     using (HttpClient httpClient = new HttpClient(httpClientHandler))
                     {
@@ -232,13 +220,7 @@ public static GithubReleasesResponse UpdateRelease(string ReleaseId)
                 {
                     httpClientHandler.AutomaticDecompression = DecompressionMethods.All;
                     httpClientHandler.SslProtocols = SslProtocols.Tls12 | SslProtocols.Tls13;
-                    httpClientHandler.ServerCertificateCustomValidationCallback = (sender, cert, chain, sslPolicyErrors) =>
-                    {
-                        if (sslPolicyErrors != SslPolicyErrors.None)
-                            return false;
-
-                        return cert.Subject.Equals("CN=*.github.com", StringComparison.OrdinalIgnoreCase);
-                    };
+                    httpClientHandler.ServerCertificateCustomValidationCallback = CertValidationCallback;
 
                     using (HttpClient httpClient = new HttpClient(httpClientHandler))
                     {
@@ -320,13 +302,7 @@ public static GithubAssetsResponse UploadAssets(string Version, string FileName,
                 {
                     httpClientHandler.AutomaticDecompression = DecompressionMethods.All;
                     httpClientHandler.SslProtocols = SslProtocols.Tls12 | SslProtocols.Tls13;
-                    httpClientHandler.ServerCertificateCustomValidationCallback = (sender, cert, chain, sslPolicyErrors) =>
-                    {
-                        if (sslPolicyErrors != SslPolicyErrors.None)
-                            return false;
-
-                        return cert.Subject.Equals("CN=*.github.com", StringComparison.OrdinalIgnoreCase);
-                    };
+                    httpClientHandler.ServerCertificateCustomValidationCallback = CertValidationCallback;
 
                     using (HttpClient httpClient = new HttpClient(httpClientHandler))
                     {
@@ -386,6 +362,23 @@ public static GithubAssetsResponse UploadAssets(string Version, string FileName,
 
             return null;
         }
+
+        private static bool CertValidationCallback(
+            HttpRequestMessage Rquest,
+            X509Certificate Cert,
+            X509Chain Chain,
+            SslPolicyErrors Errors
+            )
+        {
+            if (Errors != SslPolicyErrors.None)
+                return false;
+
+            if (Cert.Subject.Equals("CN=*.github.com", StringComparison.OrdinalIgnoreCase))
+                return true;
+
+            Program.PrintColorMessage($"[CertValidationCallback] {Cert.Subject}", ConsoleColor.Red);
+            return false;
+        }
     }
 
     public class GithubRelease : IComparable, IComparable<GithubRelease>, IEquatable<GithubRelease>

diff --git a/tools/CustomBuildTool/bin/Release/CustomBuildTool.exe b/tools/CustomBuildTool/bin/Release/CustomBuildTool.exe
diff --git a/tools/CustomBuildTool/bin/Release/CustomBuildTool.pdb b/tools/CustomBuildTool/bin/Release/CustomBuildTool.pdb