Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in peview x64 build when viewing x32 exes #41

Closed
yossizahn opened this issue May 9, 2016 · 3 comments
Closed

bug in peview x64 build when viewing x32 exes #41

yossizahn opened this issue May 9, 2016 · 3 comments
Assignees
@dmex
Labels
bug

Comments

@yossizahn
Copy link
Contributor

The x64 build of peview shows an incorrect 64 bit Image Base when viewing 32bit files.
@dmex dmex added the bug label May 10, 2016
@dmex dmex added this to the Future milestone May 10, 2016
dmex pushed a commit that referenced this issue May 26, 2016
@yossizahn @dmex
fix issue #41 (#42)
49b520a 
1) explicitly cast optional header to correct bitness, instead of allowing the compiler to decide based on the build environment. see 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680339(v=vs.85).aspx in the remarks section.
2) same for format string use "I32" insdead of "I" which allows the compiler to decide the size based on the build environment
@dmex dmex assigned dmex and unassigned wj32 May 26, 2016
@dmex
Copy link
Member

dmex commented May 26, 2016

I'll leave the ticket open until @wj32 reviews the merge

@dmex dmex reopened this May 26, 2016
@wj32
Copy link
Contributor

wj32 commented May 26, 2016

OK looks good.

@wj32 wj32 closed this as completed May 26, 2016
@dmex
Copy link
Member

dmex commented May 27, 2016

The latest nightly release includes the merged changes:
https://wj32.org/processhacker/forums/viewtopic.php?f=1&t=2315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmex dmex

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wj32 @dmex @yossizahn