Installer using incorrect service name #47

dmex · 2016-06-30T13:08:19Z

The Process Hacker setup is not correctly installing/uninstalling KPH due to using the service name KProcessHacker2 after it was renamed KProcessHacker3 about two releases ago :P

XhmikosR · 2016-06-30T13:27:40Z

So we assume no KProcessHacker2 service is running anymore?

dmex · 2016-07-01T01:59:45Z

Yes, although someone might be upgrading from an older version with KPH2 which needs to be stopped/deleted (??) but all newer versions (and the last two releases) are using KPH3

VictorVG · 2016-07-01T07:43:47Z

Changes for installer, just diff:

--- Process_Hacker_installer.iss
+++ Process_Hacker_installer.iss
@@ -332,7 +332,7 @@
 var
   dwStart: DWORD;
 begin
-  if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker2', 'Start', dwStart) then begin
+  if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker3', 'Start', dwStart) then begin
     if dwStart = 1 then
       Result := True;
   end else
@@ -386,14 +386,18 @@
   if CurStep = ssInstall then begin
     if IsServiceRunning('KProcessHacker2') then
       StopService('KProcessHacker2');
-    if IsTaskSelected('delete_KPH_service') then
       RemoveService('KProcessHacker2');
+
+    if IsServiceRunning('KProcessHacker3') then
+      StopService('KProcessHacker3');
+    if IsTaskSelected('delete_KPH_service') then
+      RemoveService('KProcessHacker3');
   end;

   if CurStep = ssPostInstall then begin
     if (KPHServiceCheck() and not IsTaskSelected('delete_KPH_service') or (IsTaskSelected('create_KPH_service'))) then begin
-      StopService('KProcessHacker2');
-      RemoveService('KProcessHacker2');
+      StopService('KProcessHacker3');
+      RemoveService('KProcessHacker3');

       if not Exec(ExpandConstant('{app}\ProcessHacker.exe'), '-installkph -s', '', SW_HIDE, ewWaitUntilTerminated, iResultCode) then begin
         // handle failure if necessary; iResultCode contains the error code
@@ -420,8 +424,8 @@
 procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);
 begin
   if CurUninstallStep = usUninstall then begin
-    StopService('KProcessHacker2');
-    RemoveService('KProcessHacker2');
+    StopService('KProcessHacker3');
+    RemoveService('KProcessHacker3');

     // When uninstalling ask user to delete Process Hacker's settings
     // based on whether the settings file exists only

XhmikosR · 2016-07-01T08:49:39Z

@VictorVG: thanks, I already have made a patch for this locally.

VictorVG · 2016-07-01T08:59:58Z

Ok!, big thanks!

VictorVG · 2016-07-01T09:17:48Z

Patch correction:

--- Process_Hacker_installer_Full.iss
+++ Process_Hacker_installer_Full.iss
@@ -332,7 +332,7 @@
 var
   dwStart: DWORD;
 begin
-  if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker2', 'Start', dwStart) then begin
+  if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker3', 'Start', dwStart) then begin
     if dwStart = 1 then
       Result := True;
   end else
@@ -384,16 +384,16 @@
   iResultCode: Integer;
 begin
   if CurStep = ssInstall then begin
-    if IsServiceRunning('KProcessHacker2') then
-      StopService('KProcessHacker2');
+    if IsServiceRunning('KProcessHacker3') then
+      StopService('KProcessHacker3');
     if IsTaskSelected('delete_KPH_service') then
-      RemoveService('KProcessHacker2');
+      RemoveService('KProcessHacker3');
   end;

   if CurStep = ssPostInstall then begin
     if (KPHServiceCheck() and not IsTaskSelected('delete_KPH_service') or (IsTaskSelected('create_KPH_service'))) then begin
-      StopService('KProcessHacker2');
-      RemoveService('KProcessHacker2');
+      StopService('KProcessHacker3');
+      RemoveService('KProcessHacker3');

       if not Exec(ExpandConstant('{app}\ProcessHacker.exe'), '-installkph -s', '', SW_HIDE, ewWaitUntilTerminated, iResultCode) then begin
         // handle failure if necessary; iResultCode contains the error code
@@ -420,8 +420,8 @@
 procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);
 begin
   if CurUninstallStep = usUninstall then begin
-    StopService('KProcessHacker2');
-    RemoveService('KProcessHacker2');
+    StopService('KProcessHacker3');
+    RemoveService('KProcessHacker3');

     // When uninstalling ask user to delete Process Hacker's settings
     // based on whether the settings file exists only

I overdid it. :) If someone has two different versions - eg branches 2.xx and 3.xx and even in different directories? Better to let you manually correct them with a copy of the program are removed.

VictorVG · 2016-07-02T04:43:03Z

Sorry, more fix - I accidentally mixed up files - my version Process_Hacker_installer_full.iss has more lines, because they would not match. Remade and tested team patch -i Process_Hacker_installer.diff - no error detected.

diff U3i Process_Hacker_installer.iss Process_Hacker_installer.iss
--- Process_Hacker_installer.iss    Sat Apr 02 17:22:51 2016
+++ Process_Hacker_installer.iss    Sat Jul 02 07:30:08 2016
@@ -270,7 +270,7 @@
 var
   dwStart: DWORD;
 begin
-  if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker2', 'Start', dwStart) then begin
+  if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker3', 'Start', dwStart) then begin
     if dwStart = 1 then
       Result := True;
   end else
@@ -327,16 +327,16 @@
   iResultCode: Integer;
 begin
   if CurStep = ssInstall then begin
-    if IsServiceRunning('KProcessHacker2') then
-      StopService('KProcessHacker2');
+    if IsServiceRunning('KProcessHacker3') then
+      StopService('KProcessHacker3');
     if IsTaskSelected('delete_KPH_service') then
-      RemoveService('KProcessHacker2');
+      RemoveService('KProcessHacker3');
   end;

   if CurStep = ssPostInstall then begin
     if (KPHServiceCheck() and not IsTaskSelected('delete_KPH_service') or (IsTaskSelected('create_KPH_service'))) then begin
-      StopService('KProcessHacker2');
-      RemoveService('KProcessHacker2');
+      StopService('KProcessHacker3');
+      RemoveService('KProcessHacker3');

       if not Exec(ExpandConstant('{app}\ProcessHacker.exe'), '-installkph -s', '', SW_HIDE, ewWaitUntilTerminated, iResultCode) then begin
         // handle failure if necessary; iResultCode contains the error code
@@ -364,8 +364,8 @@
 procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);
 begin
   if CurUninstallStep = usUninstall then begin
-    StopService('KProcessHacker2');
-    RemoveService('KProcessHacker2');
+    StopService('KProcessHacker3');
+    RemoveService('KProcessHacker3');

     // When uninstalling ask user to delete Process Hacker's settings
     // based on whether the settings file exists only

Diff attached
Process_Hacker_installer.diff.zip

XhmikosR · 2016-07-02T22:20:18Z

Thanks but don't beat yourself up; let me find some time to merge my local
changes and we can tweak it if needed.
On Jul 2, 2016 07:43, "Виктор" notifications@github.com wrote:

Sorry, more fix - I accidentally mixed up files - my version
Process_Hacker_installer_full.iss has more lines, because they would not
match. Remade and tested team patch -i Process_Hacker_installer.diff - no
error detected.

diff U3i Process_Hacker_installer.iss Process_Hacker_installer.iss
--- Process_Hacker_installer.iss Sat Apr 02 17:22:51 2016
+++ Process_Hacker_installer.iss Sat Jul 02 07:30:08 2016
@@ -270,7 +270,7 @@
var
dwStart: DWORD;
begin
if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker2', 'Start', dwStart) then begin

if RegQueryDWordValue(HKLM, 'SYSTEM\CurrentControlSet\Services\KProcessHacker3', 'Start', dwStart) then begin
if dwStart = 1 then
Result := True;
end else
@@ -327,16 +327,16 @@
iResultCode: Integer;
begin
if CurStep = ssInstall then begin

if IsServiceRunning('KProcessHacker2') then
 StopService('KProcessHacker2');
if IsServiceRunning('KProcessHacker3') then
 StopService('KProcessHacker3');
if IsTaskSelected('delete_KPH_service') then
 RemoveService('KProcessHacker2');
 RemoveService('KProcessHacker3');
end;

if CurStep = ssPostInstall then begin
if (KPHServiceCheck() and not IsTaskSelected('delete_KPH_service') or (IsTaskSelected('create_KPH_service'))) then begin
 StopService('KProcessHacker2');
 RemoveService('KProcessHacker2');
 StopService('KProcessHacker3');
 RemoveService('KProcessHacker3');
if not Exec(ExpandConstant('{app}\ProcessHacker.exe'), '-installkph -s', '', SW_HIDE, ewWaitUntilTerminated, iResultCode) then begin
// handle failure if necessary; iResultCode contains the error code
@@ -364,8 +364,8 @@
procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);
begin
if CurUninstallStep = usUninstall then begin
StopService('KProcessHacker2');

RemoveService('KProcessHacker2');

StopService('KProcessHacker3');

RemoveService('KProcessHacker3');
// When uninstalling ask user to delete Process Hacker's settings
// based on whether the settings file exists only

Diff attached
Process_Hacker_installer.diff.zip
https://github.com/processhacker2/processhacker2/files/344410/Process_Hacker_installer.diff.zip

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAVVtUNsI8C_BwOAu4MzRmZ7kOe7WTF_ks5qRexYgaJpZM4JCI8r
.

VictorVG · 2016-07-03T01:49:06Z

Ok!, I wait Your. No problem. Big thanks!

VictorVG · 2016-07-15T12:35:50Z

Also I found value KProcessHacker2 in to ./trunk/tools/ProcessHackerSetup/ProcessHackerSetup\lib/appsup.c::733 - code string is:

`serviceHandle = OpenService(scmHandle, L"KProcessHacker2", SERVICE_STOP | DELETE); `

do you needed correct this string?

VictorVG · 2016-08-29T21:52:57Z

Sorry, but my patch it causes an error in the new versions of Process Hacker due to the recording of incorrect values of the driver KProcessHacker3 Parameters\SecurityLevel=2. Because for the assembly of Process Hacker v3.0.0.144 and later it does not apply.

dmex · 2017-01-29T16:57:07Z

I patched this some time ago but forgot to update the ticket 😄

VictorVG · 2017-01-29T17:44:39Z

Ok! :)

dmex added the bug label Jun 30, 2016

dmex added this to the Future milestone Jun 30, 2016

dmex assigned XhmikosR and dmex Jun 30, 2016

dmex closed this as completed Jan 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installer using incorrect service name #47

Installer using incorrect service name #47

dmex commented Jun 30, 2016

XhmikosR commented Jun 30, 2016

dmex commented Jul 1, 2016 •

edited

VictorVG commented Jul 1, 2016 •

edited

XhmikosR commented Jul 1, 2016

VictorVG commented Jul 1, 2016

VictorVG commented Jul 1, 2016 •

edited

VictorVG commented Jul 2, 2016

XhmikosR commented Jul 2, 2016

VictorVG commented Jul 3, 2016

VictorVG commented Jul 15, 2016

VictorVG commented Aug 29, 2016

dmex commented Jan 29, 2017

VictorVG commented Jan 29, 2017

Installer using incorrect service name #47

Installer using incorrect service name #47

Comments

dmex commented Jun 30, 2016

XhmikosR commented Jun 30, 2016

dmex commented Jul 1, 2016 • edited

VictorVG commented Jul 1, 2016 • edited

XhmikosR commented Jul 1, 2016

VictorVG commented Jul 1, 2016

VictorVG commented Jul 1, 2016 • edited

VictorVG commented Jul 2, 2016

XhmikosR commented Jul 2, 2016

VictorVG commented Jul 3, 2016

VictorVG commented Jul 15, 2016

VictorVG commented Aug 29, 2016

dmex commented Jan 29, 2017

VictorVG commented Jan 29, 2017

dmex commented Jul 1, 2016 •

edited

VictorVG commented Jul 1, 2016 •

edited

VictorVG commented Jul 1, 2016 •

edited