driver work #1320
Merged
driver work #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This was
linked to
issues
Jul 27, 2022
dmex
previously requested changes
Jul 27, 2022
jxy-s
force-pushed
the
driver-work
branch
4 times, most recently
from
b545ec2
to
9ab21b2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jxy-s
force-pushed
the
driver-work
branch
2 times, most recently
from
b4693d6
to
307fb2c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ge0rdi
reviewed
Jul 28, 2022
ge0rdi
reviewed
Jul 28, 2022
ge0rdi
reviewed
Jul 28, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
ge0rdi
reviewed
Jul 28, 2022
jxy-s
force-pushed
the
driver-work
branch
2 times, most recently
from
d8da7d7
to
9997b67
Compare
jxy-s
force-pushed
the
driver-work
branch
3 times, most recently
from
72e7087
to
115be13
Compare
|
I plan to merge this PR this weekend. Please attend to reviews if you're interested in doing so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implements stricter requirements for making calls to the driver, hardens existing code, fixes SAL, contains mitigations against exploitation of the verified process, and expands the capabilities of the driver both around informing of system activity and exposing new functionality/information through the driver API.
The core of the changes here is the process state (defined in
kphapi.h). Which we track in the driver and require a certain level of state for the connected client to have in order to be authorized to make a call into the driver (defined incomms_handlers.c).