Skip to content

Commit

Permalink
♻️ Combine similar conditional check in a for...of loop
Browse files Browse the repository at this point in the history
  • Loading branch information
kghugo committed Aug 4, 2020
1 parent 3c0d892 commit ca0ecba
Showing 1 changed file with 10 additions and 14 deletions.
24 changes: 10 additions & 14 deletions utilities/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,18 @@ const shouldBeTransformed = (decl, options) => {
return false
}

if (!isIncluded(decl.prop, options.includedRules) || isIncluded(decl.prop, options.excludedRules)) {
console.log(`${decl.prop} excluded`);
return false
}

if (!isIncluded(decl.parent.selector, options.includedSelectors) || isIncluded(decl.parent.selector, options.excludedSelectors)) {
console.log(`${decl.parent.selector} excluded`);
return false
}

if (!isIncluded(decl.value, options.includedUnits) || isIncluded(decl.value, options.excludedUnits)) {
console.log(`${decl.value} excluded`);
return false
const inclusionRules = [ options.includedRules, options.includedSelectors, options.includedUnits]
const exclusionRules = [ options.excludedRules, options.excludedSelectors, options.excludedUnits]
const validationValues = [decl.prop, decl.parent.selector, decl.value]

for(const [index, value] of validationValues.entries() ){
if(! isIncluded(value, inclusionRules[index]) || isIncluded(value, exclusionRules[index]) ){
console.log(`${decl.parent.selector}{ ${decl.prop}: ${decl.value} } has been excluded`);
return false
}
}

console.log(`${decl.parent.selector}{${decl.prop}: ${decl.value}} has been wrapped with rfs()`);
console.log(`${decl.parent.selector}{ ${decl.prop}: ${decl.value} } has been wrapped with rfs()`);
return true
}

Expand Down

0 comments on commit ca0ecba

Please sign in to comment.