Replace JSON stringify library "fast-safe-stringify" by "safe-stable-stringify" #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also have removed "stable" option for json formatter, because new JSON stringification library always produces stable results with better performance
DABH
approved these changes
Jul 11, 2020
|
@DABH do you mind publishing a new version of |
vdemonchy
added a commit
to Spendesk/winston
that referenced
this pull request
Aug 6, 2021
|
@DABH Hello, I second @vladgolubev comment, would you please consider releasing a new version of the package with the json lib switch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for replacements:
From internal tests "safe-stable-stringify" is working faster and still produces correct output.
Only single disadvantage - you can't have randomness in property order, it's always stable.