Added MIT license type to package.json #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comment about this? It's very important to add an open source license to the project, as currently winston-mongodb can't be used in open source projects. |
|
+1 |
|
The license actually is MIT, it's just marked in the source code here: |
yurijmikhalevich
added a commit
that referenced
this pull request
May 23, 2014
Added MIT license type to package.json
|
@panuhorsmalahti, yes the license actually is MIT. |
|
Agreed, the license should of course be metioned in package.json. My point was that it was okay to use this package even before merging this. I was actually close to rewriting the package when I didn't know the license.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project appears to not have a license type, I recommend using MIT (another alternative would be BSD). In addition, tools like license-checker need a valid "license" property.