[wip] Test maxsize options on file transport.

lib/winston/transports/file.js

@@ -451,7 +451,7 @@ File.prototype._createStream = function () {
     .on('drain', this._onDrain)
     .on('open', function () {
       debug('file open ok', fullpath);
-      self.emit('open');
+      self.emit('open', fullpath);
       self._stream.pipe(self._dest);
     });
 

test/transports/file-maxsize.test.js

@@ -0,0 +1,84 @@
+/*
+ * file-test.js: Tests for instances of the File transport
+ *
+ * (C) 2010 Charlie Robbins
+ * MIT LICENSE
+ *
+ */
+
+const assert = require('assert');
+const exec = require('child_process').exec;
+const fs = require('fs');
+const path = require('path');
+const assume = require('assume');
+const winston = require('../../');
+
+const MESSAGE = Symbol.for('message');
+const kbStr = new Array(1024).join('-');
+const maxsizeTransport = new winston.transports.File({
+  level: 'info',
+  format: winston.format.printf(info => info.message),
+  filename: path.join(__dirname, '..', 'fixtures', 'logs', 'testmaxsize.log'),
+  maxsize: 4096
+});
+
+//
+// Log the specified kbytes to the transport
+//
+function logKbytes (kbytes) {
+  //
+  // With printf format that displays the message only
+  // winston adds exactly 0 characters.
+  //
+  for (var i = 0; i < kbytes; i++) {
+    maxsizeTransport.log({ level: 'info', [MESSAGE]: kbStr });
+  }
+}
+
+describe('File (maxsize)', function () {
+  this.timeout(10000);
+
+  before(function (done) {
+    exec('rm -rf ' + path.join(__dirname, '..', 'fixtures', 'logs', 'testmaxsize*'), done);
+  });
+
+  it('should create multiple files correctly when passed more than the maxsize', function (done) {
+    //
+    // Setup a list of files which we will later stat.
+    //
+    const files = [];
+
+    //
+    // Assets all the files have been created with the
+    // correct filesize
+    //
+    function assumeFilesCreated() {
+      files.forEach(function (file) {
+        let stats;
+        try {
+          stats = fs.statSync(file);
+          assume(stats.size).equals(4096);
+        } catch (ex) {
+          assume(stats).is.an('object', `${file} failed to open: ${ex.message}`);
+        }
+      });
+
+      done();
+    }
+
+    maxsizeTransport.on('open', function (file) {
+      console.dir(arguments);
+      const match = file.match(/(\d+)\.log$/);
+      const count = match ? match[1] : 0;
+
+      files.push(file);
+      if (files.length === 5) {
+        return assumeFilesCreated();
+      }
+
+      logKbytes(4);
+    });
+
+    logKbytes(4);
+  });
+});