-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileTransport not compatible with Node 0.10 #227
Comments
I also faced with this error. |
…n order to be compatible with the new streams2 API in Node 0.10.* (Issue winstonjs#227)
+1 I'd love to see this fixed so I could move on to node 0.10.x. Thanks. |
+1 |
Fixed in #229. Thanks for merging :) |
Can we get an npm release or am I missing something? Thanks. |
Any news on when npm release will be available? |
+1 on this |
There are still a couple of tests failing on 0.10.x after these are resolved, there will be another release. |
I'm testing with node 0.10.21 and seeing some tests still failing. For instance: ✗ Errored » Asynchronous Error The final result of "npm test" was: ✗ Errored » 122 honored ∙ 3 errored Sorry for not giving further details on what is specifically crashing in there, just wanted to mention this in case it's helpful. |
is this working yet? |
Hi @davis, have you tried with winston@0.8.0? |
I'm not sure but I think that the new Streams2 API in Node 0.10.* has an impact on winston. If I try to log with the FileTransport it only writes one statement into the log file and stops then.
Means, every following logging transaction doesn't appear in the log file.
An alternative would be to use an own WriteableStream and push it into the "stream" property, but letting winston do that by defining a filename doesn't work.
Works in
Doesn't work in
I created a little test case: winston-streams2.js - Checked it with the latest version of winston (0.6.2).
The text was updated successfully, but these errors were encountered: