Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTransport not compatible with Node 0.10 #227

Closed
akoenig opened this issue Mar 25, 2013 · 11 comments
Closed

FileTransport not compatible with Node 0.10 #227

akoenig opened this issue Mar 25, 2013 · 11 comments

Comments

@akoenig
Copy link
Contributor

akoenig commented Mar 25, 2013

I'm not sure but I think that the new Streams2 API in Node 0.10.* has an impact on winston. If I try to log with the FileTransport it only writes one statement into the log file and stops then.

Means, every following logging transaction doesn't appear in the log file.

An alternative would be to use an own WriteableStream and push it into the "stream" property, but letting winston do that by defining a filename doesn't work.

Works in

  • 0.8.22

Doesn't work in

  • 0.10.0
  • 0.10.1

I created a little test case: winston-streams2.js - Checked it with the latest version of winston (0.6.2).

@mahnunchik
Copy link

I also faced with this error.
This happens because the event 'drain' is not called.
This is article about changes in stream2 http://blog.nodejs.org/2012/12/21/streams2/

akoenig pushed a commit to akoenig/winston that referenced this issue Mar 26, 2013
…n order to be compatible with the new streams2 API in Node 0.10.* (Issue winstonjs#227)
@1o1brian
Copy link

1o1brian commented Apr 2, 2013

+1 I'd love to see this fixed so I could move on to node 0.10.x. Thanks.

@dhendo
Copy link

dhendo commented Apr 5, 2013

+1

@akoenig
Copy link
Contributor Author

akoenig commented Apr 5, 2013

Fixed in #229. Thanks for merging :)

@1o1brian
Copy link

Can we get an npm release or am I missing something?

Thanks.

@vlamic
Copy link

vlamic commented Apr 12, 2013

Any news on when npm release will be available?

@nicokruger
Copy link

+1 on this

@3rd-Eden
Copy link
Contributor

There are still a couple of tests failing on 0.10.x after these are resolved, there will be another release.

@victoruiz
Copy link

I'm testing with node 0.10.21 and seeing some tests still failing.

For instance:

✗ Errored » Asynchronous Error
in winston/transports/daily-rotate-file
in test/transports/daily-rotate-file-test.js
✗ Errored » callback not fired
in An instance of the Daily Rotate File Transport the stream() method using no options
in winston/transports/daily-rotate-file
in test/transports/daily-rotate-file-test.js

The final result of "npm test" was: ✗ Errored » 122 honored ∙ 3 errored

Sorry for not giving further details on what is specifically crashing in there, just wanted to mention this in case it's helpful.

@davis
Copy link

davis commented Oct 3, 2014

is this working yet?

@pose
Copy link
Member

pose commented Oct 4, 2014

Hi @davis, have you tried with winston@0.8.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants