DailyRotateFile transport losing rotation count after restart

[nicStuff]

It could happen that the given node process, using winston an daily file transport, gest restarted/crashes and gets pulled up again: in this case the daily file transport isn't able to see the log files generated before the restart, so the log rotation happens lately. More application restarts happen, more abandoned log files remain there.

Personally I think that it's a basic feature to correct the daily transport so this behaviour couldn't happen: for instance at startup it could search, inside the logs folder, for flies with given filename pattern and considers them.

[jci-fox]

I have seen the same behavior in the File transport. It is using the exact same code.

[nicStuff]

Hmm: for the daily transport I've made a patch, pulled to winston: #333. Tested it until now and seems to work fine.

[jci-fox]

Do you know if this was also addressed in the file transport as well? They were both having the same issue (not detecting other files already there). Do you know if that version has been pushed to npm? I did a upgrade to latest winston and I'm not seeing this pull in that version. 0.7.2 is the latest available it appears.

[nicStuff]

1. well, when I pointed out the problem I didn't found any notice from anyone about something similar on File transport (as what I saw I was the first noticing this thing)
2. My pull request is still there (and it is for daily transport, although something could be eventually extracted and used even with file transport): before seeing it on npm, who has the rights on the repo must accept the pull, then make a release with it (usually it's a long way...). This is why I made my own fix and I'm using it.

Be aware that my pull request is about daily transport, not file transport.

[jci-fox]

No problem, I figured I'd ask if you or anyone had done the same for File Transport.

[indexzero]

Duplicate of #504. And fixed by #505.