Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] DailyRotateFile is now writing to the correct file. #505

Closed
wants to merge 1 commit into from
Closed

[fix] DailyRotateFile is now writing to the correct file. #505

wants to merge 1 commit into from

Conversation

cheolgook
Copy link

This is the fix for #504 with DailyRotateFile writing to the old file if it's been deleted.

@indexzero indexzero mentioned this pull request Dec 9, 2014
Closed
@indexzero indexzero mentioned this pull request Apr 7, 2015
Closed
@AndokoChandra
Copy link

Thanks cheolgook, I have similar issues and your solution works for me.
Is there any chance this get merged to master?

@indexzero indexzero mentioned this pull request Oct 9, 2015
Closed
4 tasks
@indexzero
Copy link
Member

Thank you for your contribution As of winston@2.0.0 this transport is now a stand-alone module: winston-daily-rotate-file. Please reopen this PR. We have opened a tracking issue there to ensure it is reviewed appropriately.

@indexzero indexzero closed this Oct 9, 2015
@GlennGeenen GlennGeenen mentioned this pull request Nov 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheolgook @AndokoChandra @indexzero