-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of new Error(string)
throughout the pipeline(s). Fixes #1338, #1486
#1562
Conversation
Also tests are failing. |
…s most folks expect.
@kibertoad the previous test failure was by design since this depended on winstonjs/logform#69 being merged & published (now available in The comment about |
Decided to switch the order of the merge. Should address the concerns you mentioned @kibertoad. |
LGTM! |
Once this is merged |
…s). Fixes winstonjs#1338, winstonjs#1486 (winstonjs#1562) * [tiny dist] Whitespace. package-lock.json * [test] Add E2E integration tests with logform `errors` format. * [test] 5:00pm. Press return. * [fix test] More E2E errors coverage. * [test] Test custom error properties. * [tiny doc] Make note of duplicate coverage in `logger`. Update minor formatting. * [test] All E2E tests work except for one... * [fix test doc] All 14 variations of handling `new Error()` now work as most folks expect. * [tiny] Fix up file header. * [dist] Bump to `logform@2.1.0` * [fix tiny] Whitespace. * s/req_id/requestId/ * [fix test] Address PR comments. Add test coverage for defaultMeta over .child(additionalMeta)
There are 14 distinct entry-points for this. They are now tracked by
test/formats/errors.test.js
:This also adds new semantics to
winston
related to (and also fixing) #1486. From the updatedREADME.md
:This is need specifically for these use-cases:
The other cases are all handled by
winston.formats.errors()
and depend on winstonjs/logform#69.