Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't change behavior when message matches splat regex. #1710

Closed
wants to merge 2 commits into from
Closed

Don't change behavior when message matches splat regex. #1710

wants to merge 2 commits into from

Conversation

murrayju
Copy link

@murrayju murrayju commented Oct 1, 2019

Fixes #1709.

@murrayju
Copy link
Author

murrayju commented Oct 1, 2019

Don't see how that test failure could be related to this change... :/

@maverick1872 maverick1872 mentioned this pull request Feb 9, 2022
Open
2 tasks
@maverick1872
Copy link
Member

Per my comment in #1709 I feel like a proper resolution warrants a larger discussion.

@maverick1872 maverick1872 mentioned this pull request Feb 12, 2022
Open
@murrayju
Copy link
Author

This has been open for years without getting merged. It isn't a priority for me to invest more time into personally, so closing this.

@murrayju murrayju closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta properties omitted if message matches splat regex
2 participants
@murrayju @maverick1872