Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1567: document common transport options #1723

Merged
merged 2 commits into from Oct 27, 2019
Merged

#1567: document common transport options #1723

merged 2 commits into from Oct 27, 2019

Conversation

kwiatkk1
Copy link
Contributor

@kwiatkk1 kwiatkk1 commented Oct 24, 2019 •
edited

DABH
DABH approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely useful as indicated by the SO question and GH issue related to this with all the votes. So happy to include this in the readme -- thanks.

@DABH DABH merged commit 64744d7 into winstonjs:master Oct 27, 2019
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
@kwiatkk1 @DABH
winstonjs#1567: document common transport options (winstonjs#1723)
5b1341e 
* winstonjs#1567: document common transport options

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwiatkk1 @DABH