Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed inconsistent tests #1977

Merged
merged 1 commit into from
Dec 11, 2021
Merged

fixed inconsistent tests #1977

merged 1 commit into from
Dec 11, 2021

Conversation

fearphage
Copy link
Contributor

Object key ordering caused tests to fail inconsistently.

@fearphage
fixed inconsistent tests
6217ac8 
object key ordering caused tests to fail inconsistently
@fearphage fearphage requested review from DABH and wbt December 11, 2021 19:59
DABH
DABH approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@fearphage fearphage merged commit 7ea4381 into winstonjs:master Dec 11, 2021
@fearphage fearphage deleted the fix-inconsistent-tests branch December 11, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

@wbt wbt Awaiting requested review from wbt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fearphage @DABH