Release - v3.7.0 #2101
Release - v3.7.0 #2101
Conversation
There was a problem hiding this comment.
LGTM. Sorry I couldn't find time to do another review pass on the metadata PR, but I think the implementation is solid enough that if there are any complaints, we'll see a couple issues raised and can tackle things from there. But certainly, this implementation closes a lot of issues, and I'm very excited to see it ship :) Many thanks again for all your extra effort that went into getting this released!!!
|
Hey no worries! I didn't wanna be a cowboy is all but I am confident in the implementation. Down the road doing some performance analysis and optimizations are likely worthwhile though. Regardless it's better to move the needle forward and adjust as necessary then toiling. |
|
What is your npm username? I’ll add you… |
|
@DABH |
|
@DABH any chance you can get me added today? Would love to get it packaged and published today or early this week if possible. |
| There have also been several relatively minor improvements to documentation, and incorporation of some updated dependencies. | ||
| Compared to v3.3.3, this version fixes some issues and includes some updates to project infrastructure, | ||
| such as replacing Travis with Github CI and dependabot configuration. | ||
| There have also been several relatively minor improvements to documentation, and incorporation of some updated dependencies. |
There was a problem hiding this comment.
FYI, you should turn off automatic trimming of trailing whitespace in .md files in your IDE, as those are significant in the MD format.
|
|
||
| Patch-level updates: | ||
| - [#2075] Fix: add missing types for batching options for HTTP Transport (thanks @KylinDC) | ||
| - Various dependencies updated, quality of life & maintainability changes, etc |
There was a problem hiding this comment.
Fine for this one, but some additional detail (see past changelog examples) would probably be better in the future, like listing the PR #s for dependency bumps and noting the issue templates one separately.
|
In running final pre-publish checks, I'm seeing a high-severity vuln listed, which will show up in every project that uses this...we should probably fix that before a publish. Update: got it fixed; will work on commits now. |
|
Published. |
|
@maverick1872 I've added you on NPM for |
Once this is merged I'll run through the following steps on the
winstonjs/winstonrepository.npm publishfrom 'master'For future releases I'd love to setup a Github action to take care of all of this manually from a release that is drafted on Github or similar.