Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typescript support for custom log levels #2349

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Typescript support for custom log levels #2349

wants to merge 7 commits into from

Commits on Sep 14, 2023

  1. Add mapped types to index.d.ts 

    This update removes the "standard" utility method definitions to log to the defined log levels, and check whether they are activated and replaces them with mapped types.
This change allows for better intellisense, as well as more rigorous type checking in typescript
    @eschablowski
    eschablowski committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8780d31 View commit details
    Browse the repository at this point in the history

  2. Fix Log level enabled map 

    This is a fix to get the actual `is<Loglevel>Enabled`, which was a bug in the previous commit
    @eschablowski
    eschablowski committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    caa5fad View commit details
    Browse the repository at this point in the history

  3. Add type parameter to AbstractConfigSetLevels to allow type sensing i… 

    …n previous commits
    @eschablowski
    eschablowski committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a62643d View commit details
    Browse the repository at this point in the history

  4. Fix some misc. ts issues with the new template types

    @eschablowski
    eschablowski committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b1b6e1e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Fix some template type errors

    @eschablowski
    eschablowski committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4d96729 View commit details
    Browse the repository at this point in the history

  2. Add more rigorous type error checking

    @eschablowski
    eschablowski committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e02faf7 View commit details
    Browse the repository at this point in the history

  3. Slightly stricter type checking for setting/getting the log level

    @eschablowski
    eschablowski committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    851966c View commit details
    Browse the repository at this point in the history