Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for max listeners warning in file transport #34

Closed
wants to merge 1 commit into from
Closed

Fix for max listeners warning in file transport #34

wants to merge 1 commit into from

Conversation

temas
Copy link

@temas temas commented Sep 7, 2011

In a noisy environment line 124, and others, can quickly run into the default max listener cap. It seems to also be uselessly spammy on the logged events, but this at least disables the warning that's not helpful in this case.

… default max listener cap. It seems to also be uselessly spammy on the logged events, but this at least disables the warning that's not helpful in this case.
@indexzero
Copy link
Member

I'm not sure if this actually fixes the problem. I will investigate and see if this is the right approach

@indexzero indexzero closed this in 010e205 Sep 11, 2011
@indexzero
Copy link
Member

So basically I didn't like the setMaxListeners approach because it limited any pipe scenarios. The approach I went with is a simple mutex on the file store which wont add the drain listener if it already has one from this file transport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants