Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in samples #318

Merged
merged 3 commits into from
May 20, 2019
Merged

Fix spelling in samples #318

merged 3 commits into from
May 20, 2019

Conversation

pram
Copy link
Contributor

@pram pram commented May 20, 2019

Fixing spelling

@oleg-nenashev
Copy link
Member

Good news, typos have test coverage 🤦‍♂

1) Test Failure : winswTests.Configuration.ExamplesTest.allOptionsConfigShouldDeclareDefaults
     String lengths are both 61. Strings differ at index 28.
  Expected: "This service is a service cratead from a sample configuration"
  But was:  "This service is a service created from a sample configuration"
  ---------------------------------------^

@oleg-nenashev oleg-nenashev merged commit 79671f4 into winsw:master May 20, 2019
@oleg-nenashev
Copy link
Member

Thanks @pram !

@nxtn nxtn added this to the 2.3.0 milestone Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants