Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that environment variables are loaded before resolving configurations #361

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Ensure that environment variables are loaded before resolving configurations #361

merged 1 commit into from
Apr 6, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 18, 2020 •
edited

Closes #238
Closes #305

Workaround for v2.

@nxtn nxtn added the bug label Mar 31, 2020
@nxtn nxtn added this to the 2.x milestone Mar 31, 2020
@nxtn nxtn changed the title [NO MERGE] TEST environment variable expansion Load environment variables first Mar 31, 2020
@nxtn nxtn marked this pull request as ready for review March 31, 2020 02:46
@oleg-nenashev oleg-nenashev changed the title Load environment variables first Ensure that environment variables are loaded before resolving configurations Apr 6, 2020
oleg-nenashev
oleg-nenashev approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to miss this pull request entirely. :shipit:

@oleg-nenashev oleg-nenashev merged commit 9bae4ca into winsw:master Apr 6, 2020
@nxtn nxtn deleted the expand branch April 6, 2020 07:41
@nxtn nxtn modified the milestones: 2.Next, 2.7.0 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

PowerShell environment variables not honoured unable to use environment variable
2 participants
@nxtn @oleg-nenashev