Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve P/Invoke signatures #362

Merged
merged 6 commits into from
Mar 25, 2020
Merged

Improve P/Invoke signatures #362

merged 6 commits into from
Mar 25, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 19, 2020

Based on #356

When in doubt, read the docs.

@oleg-nenashev oleg-nenashev changed the base branch from master to test-4.x January 22, 2020 16:15
@oleg-nenashev oleg-nenashev changed the base branch from test-4.x to master January 22, 2020 16:15
@nxtn nxtn mentioned this pull request Jan 31, 2020
Merged
@nxtn
Copy link
Contributor Author

nxtn commented Mar 24, 2020

@oleg-nenashev I guess the CI needs to be reconfigured?

@oleg-nenashev
Copy link
Member

yes, #447

@oleg-nenashev oleg-nenashev added the internal Internal changes and maintenance label Mar 25, 2020
oleg-nenashev
oleg-nenashev approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see anything wrong here, so I trust your expertise @NextTurn

@nxtn nxtn merged commit 6280a68 into winsw:master Mar 25, 2020
@nxtn nxtn deleted the pinvoke branch March 25, 2020 13:45
@nxtn nxtn added this to the 2.x milestone Mar 25, 2020
@nxtn nxtn modified the milestones: 2.Next, 2.7.0 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
internal Internal changes and maintenance
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nxtn @oleg-nenashev