Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix executable path and XML config file resolution on .NET Core #389

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix executable path and XML config file resolution on .NET Core #389

merged 1 commit into from
Jan 30, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 29, 2020

Fixes #388

@oleg-nenashev oleg-nenashev changed the title Fix executable path on .NET Core Fix executable path and XML config file resolution on .NET Core Jan 29, 2020
oleg-nenashev
oleg-nenashev approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to test it on older platforms like .NET 2.0 before merging, but it looks good to me. Thanks!

jetersen
jetersen approved these changes Jan 29, 2020
View reviewed changes
Copy link

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-nenashev oleg-nenashev merged commit 5c3865f into winsw:master Jan 30, 2020
@nxtn nxtn deleted the exepath branch January 30, 2020 10:17
@nxtn nxtn modified the milestone: 2.5.0 Mar 25, 2020
@nxtn nxtn mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

XML file name (file not found error)
3 participants
@nxtn @jetersen @oleg-nenashev