Support security descriptor string #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxtn
changed the title
oleg-nenashev
requested changes
Mar 27, 2020
There was a problem hiding this comment.
securityDescriptor looks good to me, we just need to ensure that the required format is properly documented in the documentation. Speaking of that, requesting changes to get it documented in https://github.com/winsw/winsw/blob/master/doc/xmlConfigFile.md
|
Oh, sorry about that. Should I revert the merge?
…On Sun, Mar 29, 2020, 10:58 Next Turn ***@***.***> wrote:
But this PR isn't complete yet?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#431 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIF635MV45P42TFJP2DRJ4ET3ANCNFSM4LANEPIQ>
.
|
|
I've added subsequent changes in #392. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Hold for #392
Possible property names:
<securtityDescriptor><securtityDescriptorString><securtityDescriptorSddl><stringSecurtityDescriptor>