Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split commands into functions #465

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Split commands into functions #465

merged 1 commit into from
Apr 6, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Mar 31, 2020

Believe it or not, this accelerates the start-up.

@nxtn nxtn added this to the 2.x milestone Mar 31, 2020
oleg-nenashev
oleg-nenashev approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, likely. Not sure whether it is visible to users.

@nxtn
Copy link
Contributor Author

nxtn commented Apr 3, 2020

Not sure whether it is visible to users.

The function names will appear in a stack trace.

@nxtn nxtn added internal Internal changes and maintenance and removed enhancement labels Apr 3, 2020
@nxtn nxtn requested a review from oleg-nenashev April 3, 2020 06:09
@oleg-nenashev oleg-nenashev merged commit 638d78f into winsw:master Apr 6, 2020
@nxtn nxtn deleted the commands branch April 6, 2020 07:38
@nxtn nxtn modified the milestones: 2.Next, 2.7.0 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
internal Internal changes and maintenance
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nxtn @oleg-nenashev