Set up CI with Azure Pipelines #477
Conversation
It is pretty much unused except codesigning of the binaries. Well, at least it used to be so in previous build flow versions. Line 5 in fef7d7e |
Are the binaries signed in the winsw-release build? |
No. Everything should happen in the common build flow. Release flow uses the same appveyor.yml, except the versioning scheme and deployment targets |
|
Then when do you sign the binaries with the real signing key? Automatically or manually? |
|
There is no signing with a real key at the moment, stub signing has been in place since 2013 or so. My personal signing key cannot be deployed on the release environment, and cutting releases from a local setup was a no-go option so far. Indeed it should change. IIRC it was even documented at some point, but I cannot find a trace of it now. Will create a new ticket |
|
Oh I see. Every release artifact has a different public key! It's worse than none. #435 |
|
Hard to argue. I do not remember a reason why I opted to this approach at that time, but changing it is a right thing to do. Will cut 2.7.0 as is, and then we can tweak the flow for further releases |
| @@ -1,39 +0,0 @@ | |||
| # WinSW Developer Information | |||
There was a problem hiding this comment.
Could we revert it for now and add a disclaimer that the process is subject to change? Then we can merge it and add patches on the top of it
There was a problem hiding this comment.
I don't understand why we put this file in the repo. It's internal for maintainers. External contributors should look into CONTRIBUTING.md.
There was a problem hiding this comment.
I am fine to rename it to MAINTAINERS.md and move to docs. Will do as a separate PR
|
One of the tests failed on Azure DevOps: https://dev.azure.com/winsw/winsw/_build/results?buildId=2&view=logs&j=72b59a5c-f9fa-5437-adfc-3f855724a45f&t=706f6d43-7b36-5d52-2781-608600615bec . I will investigate it later today (after 7PM UTC) or tomorrow. Feel free to tweak the build Pipeline as needed, without waiting for my reviews |
That's a false proposition. I have to wait for your reviews to merge PRs. |
|
Oh, right. You do not have admin access in the repo. I can get it fixed |
It's not a problem of the access.. It's the code owners. |
|
Admins can override the branch protection rules if needed. Anyway, I relaxed the branch protection for now so that you are not blocked @NextTurn |
I'm not familiar with the user rules on GitHub. That's all for me:
|
The workflows are described on the Wiki page. It's internal right now, but it's unlikely that it needs to be public at all.
How do you use the .snk file in CI?
Contributes to #493