Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strong name signing #478

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Remove strong name signing #478

merged 1 commit into from
Apr 16, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 3, 2020 •
edited

Closes #435

- Define SIGN_ASSEMBLY environment variable to true in release builds.
- Move key files to a subdirectory.

We don't really strong-name assemblies at the moment.

@nxtn nxtn added the build-flow label Apr 3, 2020
@nxtn nxtn added this to the 2.x milestone Apr 3, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner April 3, 2020 02:42
@nxtn nxtn changed the title Only strong-name in releases Remove strong-naming Apr 6, 2020
@nxtn nxtn changed the title Remove strong-naming Remove strong name signing Apr 6, 2020
@nxtn
Copy link
Contributor Author

nxtn commented Apr 16, 2020

Merging to unblock the [InternalsVisibleTo] attribute. We can restore it anytime once we have real strong-name signing.

@nxtn nxtn merged commit ea6cb80 into winsw:master Apr 16, 2020
@nxtn nxtn deleted the sign branch April 16, 2020 04:20
@nxtn nxtn modified the milestones: 2.Next, 2.8.0 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev oleg-nenashev is a code owner

Assignees
No one assigned
Labels
build-flow
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Remove strong name signing
1 participant
@nxtn