Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versioning of WinSW builds #495

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix versioning of WinSW builds #495

merged 1 commit into from
Apr 8, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 8, 2020 •
edited

Fixes #488

Contributes to #493

@nxtn nxtn added the build-flow label Apr 8, 2020
@nxtn nxtn added this to the 2.Next milestone Apr 8, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner April 8, 2020 08:36
oleg-nenashev
oleg-nenashev approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it. The downside is that we will need to finalize the Azure devops flow before doing more releases, but I believe we are on a good track there

@oleg-nenashev oleg-nenashev changed the title Fix versioning Fix versioning of WinSW builds Apr 8, 2020
@oleg-nenashev
Copy link
Member

I relaxed the merge rules for now

@nxtn
Copy link
Contributor Author

nxtn commented Apr 8, 2020

The point is that I don't want to see a bunch of failures in pipelines runs. Will fix the test first.

@oleg-nenashev
Copy link
Member

Will fix the test first.

Or just disable it for now

@oleg-nenashev oleg-nenashev merged commit 00c9f37 into winsw:master Apr 8, 2020
@nxtn nxtn deleted the version branch April 8, 2020 10:28
@nxtn nxtn modified the milestones: 2.Next, 2.8.0 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug build-flow
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Wrong version reported by winsw executable
2 participants
@nxtn @oleg-nenashev