Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the failing Runaway Process Killer test #496

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Skip the failing Runaway Process Killer test #496

merged 1 commit into from
Apr 8, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 8, 2020

No description provided.

@nxtn nxtn added the tests label Apr 8, 2020
@nxtn nxtn added this to the 2.Next milestone Apr 8, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner April 8, 2020 09:19
@nxtn nxtn changed the title Replace pause with sleep Skip the failing test Apr 8, 2020
@oleg-nenashev oleg-nenashev merged commit aa29a3c into winsw:master Apr 8, 2020
@oleg-nenashev oleg-nenashev changed the title Skip the failing test Skip the failing Runaway Process Killer test Apr 8, 2020
@oleg-nenashev
Copy link
Member

It was green in the test but then exploded on CI with another test

D:\a\1\s\src\Test\winswTests>set  1>C:\Users\VssAdministrator\AppData\Local\Temp\winswTests_1ttjovkm.oam\env.properties 
  X ShouldPropagateVariablesInUppercase [135ms]
  Error Message:
   Wrong line in the parsed Set output file: 
  Stack Trace:
     at winswTests.Util.FilesystemTestHelper.parseSetOutput(String filePath) in D:\a\1\s\src\Test\winswTests\Util\FilesystemTestHelper.cs:line 40
   at winswTests.Util.ProcessHelperTest.ShouldPropagateVariablesInUppercase() in D:\a\1\s\src\Test\winswTests\Util\ProcessHelperTest.cs:line 31

  Standard Output Messages:
 Created the temporary directory: C:\Users\VssAdministrator\AppData\Local\Temp\winswTests_1ttjovkm.oam
 2020-04-08 10:11:53,017 INFO  - Started process 5328
 2020-04-08 10:11:53,017 INFO  - Started process 5328
 2020-04-08 10:11:53,017 INFO  - Started process 5328
 2020-04-08 10:11:53,017 INFO  - Started process 5328

@nxtn nxtn deleted the test branch April 8, 2020 10:27
@nxtn
Copy link
Contributor Author

nxtn commented Apr 8, 2020

I can't figure out why this test only failed in this CI. It never failed in the CI builds of my fork.

@nxtn
Copy link
Contributor Author

nxtn commented Apr 8, 2020

Now it seems that this only happens on the master branch.

@nxtn nxtn modified the milestones: 2.Next, 2.8.0 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nxtn @oleg-nenashev