Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend default native fields option #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hacknug
Copy link

@hacknug hacknug commented Mar 22, 2019

This PR adds most of the default native fields discussed in #3.

Breaking Changes

  • The Custom option now requires you to write a valid CSS selector instead of just the ID of the element. This change has been introduced to explicitly acknowledge users can select multiple metaboxes to move at once. Previously it would've required them to write something like first-id, #second-id.

Other Changes

  • Options inside the native select element are now grouped by category (Core, WooCommerce, Plugins, and Other)
  • Options from the WooCommerce and Plugins categories are now shown only when the required plugin is active (not just installed)
  • Instead of having a common option for both Yoast SEO and The SEO Framework, they now have independent options

Copy link
Member

@marcusforsberg marcusforsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacknug Thanks! I'm interested in merging this if you have the time to resolve the conflicts by re-doing this on a fresh checkout. Please ensure you have Prettier installed so the code is formatted as per our standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants