Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Switch to node-saml? #18

Open
FossPrime opened this issue Oct 8, 2021 · 1 comment
Open

[FR] Switch to node-saml? #18

FossPrime opened this issue Oct 8, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@FossPrime
Copy link
Contributor

FossPrime commented Oct 8, 2021

Would you consider a PR to switch to https://github.com/node-saml/node-saml? It's now in use by passport and helix.

https://github.com/Clever/saml2 is written in CoffeeScript, making it hard to work on, test and read. More concerning is it's falling behind on security patches to xmldom. Which weakens the security features of SAML.

Both implementations stick fairly close the the SAML standard, unfortunately the translations of the XML properties are not compatible... so it would be a significant breaking change. We could add a compatibility layer for the simplest use cases... but I would simply make a new major release. An example of the issue is force_authn... in node-saml it's called forceAuthn.

This would also add support for tons of SAML2 features that are missing in Clever's implementation, like loginFailureUrl... node-saml is also working on logoutFailureUrl.

@rlunden
Copy link
Member

rlunden commented Oct 25, 2022

Hey @FossPrime,

Sorry for the late reply, but that sounds good.

@marcusforsberg marcusforsberg added enhancement New feature or request help wanted Extra attention is needed labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants