Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Sequence implementation class #14

Merged
merged 9 commits into from
Oct 16, 2017

Conversation

couzic
Copy link
Contributor

@couzic couzic commented Oct 12, 2017

#11

@winterbe
Copy link
Owner

Thanks for your hard work. I've looked over the various changes, looks good to me.

I just have two minor notes:

  • As you already mentioned in Separate operation API from implementation #11 I would also prefer to just support user-defined operations via mixins. Dropping one function would make the API a bit simpler. I would prefer the name extendSequence(mixin) instead of augmentSequenceWithMixin().
  • Please squash your commits into a single commit.

@couzic
Copy link
Contributor Author

couzic commented Oct 16, 2017

I made the change to extendSequence(), I also typed the input so it only accepts a class.

As for squashing, I think github provides a way for you to do it in a single click:
https://help.github.com/assets/images/help/pull_requests/select-squash-and-merge-from-drop-down-menu.png
I've never used it, but I understand it could do the job.

@winterbe
Copy link
Owner

Thanks for the hint, wasn't aware of this option. I'll merge your changes soon.

@winterbe winterbe merged commit 9e3fcb3 into winterbe:master Oct 16, 2017
@couzic couzic deleted the hide-sequence-implementation branch October 16, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants